:sparkles: paginating alpha sort | simplifying sort pagination

plugins/cia-endpoints/includes/class.make-sortby.php

@@ -19,6 +19,28 @@ class Make_Sort_By extends WP_REST_Controller {
             ),
         ]);
     }
+    function _get_args($params) {
+        $args = [
+            'posts_per_page' => 99,
+            'page' => 1
+        ];
+        if(intval($params['limit']) > 0) {
+            $args['posts_per_page'] = intval($params['limit']);
+        }
+        if(intval($params['p']) > 1) {
+            $args['page'] = intval($params['p']);
+        }
+        return $args;
+    }
+    function _get_page_items($res, $request) {
+        // Get parameters from request,
+        // /?limit=<num>&?orderby=<str>&?order=<str>
+        $args = $this->_get_args($request->get_params());
+        
+        $index_from_page = $args['page'] - 1;
+        $offset = array_chunk($res, $args['posts_per_page']);
+        return $offset[$index_from_page];
+    }
 
     public function by_alpha( $request ) {
         global $wpdb;
@@ -33,7 +55,7 @@ class Make_Sort_By extends WP_REST_Controller {
         ));
         wp_reset_postdata();
 
-        return new WP_REST_Response( $this->prepare_items_for_reponse($res), 200 );
+        return new WP_REST_Response( $this->prepare_items_for_reponse($this->_get_page_items($res, $request)), 200 );
     }
 
     public function by_material( $request ) {
@@ -66,7 +88,7 @@ class Make_Sort_By extends WP_REST_Controller {
             $end, $time, $this->post_type
         ));
         wp_reset_postdata();
-        return new WP_REST_Response( $this->prepare_items_for_reponse($res), 200 );
+        return new WP_REST_Response( $this->prepare_items_for_reponse($this->_get_page_items($res, $request)), 200 );
     }
 
     public function by_current( $request ) {
@@ -112,24 +134,7 @@ class Make_Sort_By extends WP_REST_Controller {
             $start, $time, $time, $end, $time, $this->post_type
         ));
         wp_reset_postdata();
-
-        // Get parameters from request,
-        // /?limit=<num>&?orderby=<str>&?order=<str>
-        $args = array(
-            'posts_per_page' => -1,
-            'page' => 1
-        );
-        $params = $request->get_params();
-        if(intval($params['limit']) > 0) {
-            $args['posts_per_page'] = intval($params['limit']);
-        }
-        if(intval($params['p']) > 1) {
-            $args['page'] = intval($params['p']);
-        }
-        $index_from_page = $args['page'] - 1;
-        $offset = array_chunk($res, $args['posts_per_page']);
-        $page = $offset[$index_from_page];
-        return new WP_REST_Response( $this->prepare_items_for_reponse($page), 200 );
+        return new WP_REST_Response( $this->prepare_items_for_reponse($this->_get_page_items($res, $request)), 200 );
     }
     
     public function by_upcoming( $request ) {
@@ -152,7 +157,7 @@ class Make_Sort_By extends WP_REST_Controller {
     }
 
     public function prepare_items_for_reponse( $items ) {
-        $collection = array();
+        $collection = [];
         forEach( $items as $key => $item ) $collection[$key] = default_post_format($item, false);
         return $collection;
     }