:recycle: trimming down custom sort code | adding subntype param to regular endpoints

README.md

 ```
 docker-compose exec -T craft-db mysqldump -u root -p current_cia | gzip > /home/<user_name>/backups/"`date +"%Y-%m-%d"`"-craftdb-backup.sql.gz
 ```
-2. On your development machine: `rsync -av <user>@<host>:/home/<user>/<date>-craftdb-backup.sql.gz <local directory>`
+2. On your development machine: `rsync -av <user>@<host>:/home/<user>/<date>-craftdb-backup.sql.gz <local directory>`
+
+```mysql
+update wp_posts
+   set guid = replace(guid, 'http://old', 'http://143.110.234.41:8080/');
+```

plugins/cia-endpoints/cia-end-points.php

     return str_replace('_', '-', $input);
 }
 
+function _make_sorts($post_types, $sorts_types) {
+    foreach ($sorts_types as $sort) {
+        $unsnaked = _unsnake($sort);
+        foreach ($post_types as $type) {
+            $sort_controller = new Make_Sort_By($type, $sort);
+            $sort_controller->register_custom_route("$type/$unsnaked");
+        }
+    }
+}
+
 add_action( 'rest_api_init', function () {
     /**
-     * Custom endpoints
+     * Custom post type endpoints
      */
     $types = get_all_post_types();
     foreach($types as $type) {
     }
     
     /**
-     * Sticky Endpoint
+     * Sticky endpoint
      */
     $sticky_controller = new Make_Sticky_Endpoint();
     $sticky_controller->register_custom_route('sticky');
     /**
      * Craft in America custom sort_types
      */
-    $artist_sorts = ['by_alpha', 'by_material', 'by_episode'];
-    foreach ($artist_sorts as $sort) {
-        $unsnaked = _unsnake($sort);
-        $sort_controller = new Make_Sort_By('artist', $sort);
-        $sort_controller->register_custom_route("artist/$unsnaked");
-    }
-
+    $artist_sorts = ['by_alpha'];
+    $by_alpha_types = ['artist'];
+    _make_sorts($by_alpha_types, $artist_sorts);
+    
     $date_sorts = ['by_past', 'by_current_and_upcoming'];
-    $date_types = ['exhibition', 'event'];
-    foreach ($date_sorts as $sort) {
-        $unsnaked = _unsnake($sort);
-        foreach ($date_types as $date_type) {
-            $sort_controller = new Make_Sort_By($date_type, $sort);
-            $sort_controller->register_custom_route("$date_type/$unsnaked");
-        }
-    }
+    $by_date_types = ['exhibition', 'event'];
+    _make_sorts($by_date_types, $date_sorts);
     
     $episode_sorts = ['by_episode'];
-    $episode_types = ['artist','exhibition', 'event'];
-    foreach ($episode_sorts as $sort) {
-        $unsnaked = _unsnake($sort);
-        foreach ($episode_types as $episode_type) {
-            $sort_controller = new Make_Sort_By($episode_type, $sort);
-            $sort_controller->register_custom_route("$episode_type/$unsnaked");
-        }
-    }
+    $by_episode_types = [
+        'artist', 'guide', 'short'
+    ];
+    _make_sorts($by_episode_types, $episode_sorts);
+    
+    $material_sorts = ['by_material'];
+    $by_material_types = [
+        'artist', 'guide', 'short',
+        'object', 'publication',
+    ];
+    _make_sorts($by_material_types, $material_sorts);
 });
 
 /**

plugins/cia-endpoints/includes/class.make-endpoint.php

         if($params['order']) {
             $args['order'] = $params['order'];
         }
+        // Unify interface for post categories and <type> subtypes
+        // See:custom-taxonomies.php for a list of custom subtypes
+        if($params['type']) {
+            $taxonomy_name = $this->post_type . '_type';
+            if($this->post_type == 'post') { $taxonomy_name = 'category'; }
+            $args['tax_query'] = array(
+                [
+                    'taxonomy' => $taxonomy_name,
+                    'field'    => 'slug',
+                    'terms'    => $params['type']
+                ]
+            );
+        }
 
         return new WP_REST_Response( $this->prepare_all_items_for_response($args), 200 );
     }

plugins/cia-post-types/includes/custom-taxonomies.php

 <?php
     function create_materials_taxonomy() {
-        $post_types_that_show_materials = [ 'artist', 'exhibition', 'event', 'guide', 'publication', 'object', 'short' ];
+        $post_types_that_show_materials = [
+            'artist',
+            'short',
+            'guide',
+            'exhibition',
+            'event',
+            'object',
+            'publication',
+        ];
         register_taxonomy('material', $post_types_that_show_materials, ['label' => 'Materials']);
     }
     function create_types_taxonomy() {

plugins/cia-post-types/includes/custom-types.php

         return [
             'artist',
             'episode',
-            'event',
-            'exhibition',
-            'guide',
             'short',
+            'guide',
+            'exhibition',
+            'event',
             'object',
             'publication',
-            // 'talk',
-            // 'technique',
-            // 'profile',
-            // 'product'
         ];
     }
 
             case 'short':
                 return 'dashicons-video-alt3';
                 break;
-
-            case 'object';
-                return 'dashicons-visibility';
-                break;
             case 'guide';
                 return 'dashicons-edit';
                 break;
             case 'technique';
                 return 'dashicons-art';
                 break;
-            case 'place';
-                return 'dashicons-admin-site';
-                break;
-            case 'release';
-                return 'dashicons-media-text';
-                break;
-            case 'profile';
-                return 'dashicons-businessman';
+            case 'object';
+                return 'dashicons-visibility';
                 break;
             case 'publication';
                 return 'dashicons-book';
                 break;
-            case 'article';
-                return 'dashicons-networking';
-                break;
             default:
                 return 'dashicons-admin-post';
         endswitch;