:recycle: moving some functions around | capitalize custom type letter in menu

plugins/cia-endpoints/includes/formats.php

@@ -1,4 +1,12 @@
 <?php
+function make_taxonomy_endpoint_for( $terms ) {
+    $type_slugs = [];
+    foreach ($terms as $type_slug):
+        array_push($type_slugs, $type_slug->slug);
+    endforeach;
+    return $type_slugs;
+}
+
 
 function default_post_format( $item ) {
     $filtered = array();
@@ -12,22 +20,22 @@ function default_post_format( $item ) {
 
     $filtered[hero] = get_post_meta( $item->ID, 'hero_header', true );
 
-    if($item->post_type === 'artist') {
-        $filtered[sortname] = get_post_meta( $item->ID, 'artist-sort-name', true );
-        $material_slugs = [];
-        foreach (get_the_terms( $item, 'material' ) as $material_slug):
-            array_push($material_slugs, $material_slug->slug);
-        endforeach;
-        $filtered[materials] = $material_slugs;
+    // Materials + type endpoints
+    // if($item->post_type === 'artist' || $item->post_type === 'event' || $item->post_type === 'exhibition') {
+    $posts_with_type = ['artist', 'exhbition', 'event'];
+    if(in_array($item->post_type, $posts_with_type)) {
+        $filtered[materials] = make_taxonomy_endpoint_for(get_the_terms( $item, 'material' ));
+        $filtered[type] = make_taxonomy_endpoint_for(get_the_terms( $item, $item->post_type . '_type' ));
     }
     
-    // Parse category IDs and store just the slugs
-    $category_slugs = [];
-    foreach (wp_get_post_categories( $item->ID ) as $id):
-        $category = get_category($id);
-        array_push($category_slugs, $category->slug);
-    endforeach;
-    $filtered[categories] = $category_slugs;
+    // Custom fields endpoint
+    if($item->post_type === 'artist') $filtered[sortname] = get_post_meta( $item->ID, 'artist-sort-name', true );
+
+    // Post categories and tags (store just the slugs)
+    if($item->post_type === 'post') {
+        $filtered[categories] = make_taxonomy_endpoint_for(get_the_terms( $item, 'category' ));
+        $filtered[tags] = make_taxonomy_endpoint_for(get_the_terms( $item, 'post_tag' ));
+    }
 
     return $filtered;
 }

plugins/cia-post-types/cia-post-types.php

@@ -19,6 +19,8 @@ if ( ! defined( 'WPINC' ) ) { die; }
 require_once 'includes/cmb2/init.php';
 
 include('includes/custom-types.php');
+include('includes/custom-taxonomies.php');
+include('includes/custom-metaboxes.php');
 include('includes/p2p-mappings.php');
 
 /**
@@ -45,7 +47,7 @@ class PostType {
     /** Register custom post type call-back */
     public function register_post_type() {
         $args = [
-            'label'              => esc_html( $this->post_type, 'test-plugin' ),
+            'label'              => esc_html( ucfirst($this->post_type), 'test-plugin' ),
             'public'             => true,
             'menu_position'      => 47,
             'menu_icon'          => $this->icon,
@@ -74,109 +76,13 @@ endforeach;
 /**
  * Create taxonomies
  */
-
 add_action('init', 'create_materials_taxonomy'); 
-function create_materials_taxonomy() {
-    $post_types_that_show_materials = [ 'artist', 'exhibition', 'event' ];
-    register_taxonomy('material', $post_types_that_show_materials, [ "label" => "Materials"]);
-}
-
-add_action('init', 'create_artist_types_taxonomy'); 
-function create_artist_types_taxonomy() {
-    $post_types_that_show_artist_types = [ 'artist' ];
-    register_taxonomy('artist type', $post_types_that_show_artist_types, [ "label" => "Artist Type"]);
-}
-
-add_action('init', 'create_event_types_taxonomy'); 
-function create_event_types_taxonomy() {
-    $post_types_that_show_event_types = [ 'event' ];
-    register_taxonomy('event type', $post_types_that_show_event_types, [ "label" => "Event Type"]);
-}
-
-add_action('init', 'create_exhibit_types_taxonomy'); 
-function create_exhibit_types_taxonomy() {
-    $post_types_that_show_exhibit_types = [ 'exhibition' ];
-    register_taxonomy('Exhibition type', $post_types_that_show_exhibit_types, [ "label" => "Exhibition Type"]);
-}
-/* Plugin Logic -- END * /
+add_action('init', 'create_types_taxonomy'); 
 
 /**
- * Custom Fields
- * Defining our HERO, and Name override fields
+ * Create CMB Metaboxes
  */
 add_action( 'cmb2_admin_init', 'cmb2_hero_metaboxes' );
-
-function sanitize_hero_urls( $value, $field_args, $field ) {
-    $encoded = wp_json_encode( array( 'url' => $value ), true );
-    return $encoded;
-}
-
-function cmb_hero_render_row_cb( $field_args, $field ) {
-    $id          = $field->args( 'id' );
-    $label       = $field->args( 'name' );
-    $name        = $field->args( '_name' );
-    $value       = $field->escaped_value();
-    $description = $field->args( 'description' );
-    // !: Impossible to fine " conversion
-    $decoded     = json_decode( str_replace('"', '"', $value), true );
-    ?>
-    <div class="custom-field-row">
-        <p>
-            <label for="<?php echo $id; ?>"><?php echo $label; ?></label>
-            <input style="width: 100%;" id="<?php echo $id; ?>" type="text" name="<?php echo $name; ?>" 
-                value="<?php echo $decoded['url']; ?>"/>
-        </p>
-        <p class="description"><?php echo $description; ?></p>
-    </div>
-    <?php
-}
-
-/**
- * Define the metabox and field configurations.
- */
-function cmb2_hero_metaboxes() {
-
-    /**
-     * Initiate the metabox
-     */
-    $cmb = new_cmb2_box( array(
-        'id'            => 'hero_metabox',
-        'title'         => __( 'Hero', 'cmb2' ),
-        'object_types'  => array( 'artist', ), // Post type
-        'context'       => 'normal',
-        'priority'      => 'high',
-        'show_names'    => true, // Show field names on the left
-        'show_in_rest'  => WP_REST_Server::READABLE
-        // 'cmb_styles' => false, // false to disable the CMB stylesheet
-        // 'closed'     => true, // Keep the metabox closed by default
-    ) );
-
-    // URL text field
-    $cmb->add_field( array(
-        'name'             => __( 'YouTube URL', 'cmb2' ),
-        'desc'             => __( 'Video for the hero section to display', 'cmb2' ),
-        'id'               => 'hero_header',
-        'type'             => 'text',
-        'sanitization_cb'  => 'sanitize_hero_urls',
-        'render_row_cb' => 'cmb_hero_render_row_cb'
-    ) );
-}
-
 add_action( 'cmb2_admin_init', 'cmb2_artist_sort_metaboxes' );
-function cmb2_artist_sort_metaboxes() {
-    $cmb = new_cmb2_box( array(
-        'id'            => 'artist_sort_metabox',
-        'title'         => __( 'Name Override', 'cmb2' ),
-        'object_types'  => array( 'artist' ),
-        'context'       => 'normal',
-        'priority'      => 'high',
-        'show_names'    => true,
-        'show_in_rest'  => WP_REST_Server::READABLE
-    ) );
-    $cmb->add_field( array(
-        'name'             => __( 'Alternate Name', 'cmb2' ),
-        'desc'             => __( 'Name to use for alphabetical sorting', 'cmb2' ),
-        'id'               => 'artist-sort-name',
-        'type'             => 'text'
-    ) );
-}
+
+/* Plugin Logic -- END * /

plugins/cia-post-types/includes/custom-metaboxes.php

@@ -0,0 +1,71 @@
+<?php
+    /**
+     * Custom Fields
+     * Defining our HERO, and Name override fields
+     */
+    function sanitize_hero_urls( $value, $field_args, $field ) {
+        $encoded = wp_json_encode( array( 'url' => $value ), true );
+        return $encoded;
+    }
+
+    function cmb_hero_render_row_cb( $field_args, $field ) {
+        $id          = $field->args( 'id' );
+        $label       = $field->args( 'name' );
+        $name        = $field->args( '_name' );
+        $value       = $field->escaped_value();
+        $description = $field->args( 'description' );
+        // !: Impossible to fine &quot; conversion
+        $decoded     = json_decode( str_replace('&quot;', '"', $value), true );
+        ?>
+        <div class="custom-field-row">
+            <p>
+                <label for="<?php echo $id; ?>"><?php echo $label; ?></label>
+                <input style="width: 100%;" id="<?php echo $id; ?>" type="text" name="<?php echo $name; ?>" 
+                    value="<?php echo $decoded['url']; ?>"/>
+            </p>
+            <p class="description"><?php echo $description; ?></p>
+        </div>
+        <?php
+    }
+
+    /**
+     * Define the metabox and field configurations.
+     */
+    function cmb2_hero_metaboxes() {
+
+        /**
+         * Initiate the metabox
+         */
+        $cmb = new_cmb2_box( array(
+            'id'            => 'hero_metabox',
+            'title'         => __( 'Hero', 'cmb2' ),
+            'object_types'  => array( 'artist', ), // Post type
+            'show_in_rest'  => WP_REST_Server::READABLE
+        ) );
+
+        // URL text field
+        $cmb->add_field( array(
+            'name'             => __( 'YouTube URL', 'cmb2' ),
+            'desc'             => __( 'Video for the hero section to display', 'cmb2' ),
+            'id'               => 'hero_header',
+            'type'             => 'text',
+            'sanitization_cb'  => 'sanitize_hero_urls',
+            'render_row_cb' => 'cmb_hero_render_row_cb'
+        ) );
+    }
+
+    function cmb2_artist_sort_metaboxes() {
+        $cmb = new_cmb2_box( array(
+            'id'            => 'artist_sort_metabox',
+            'title'         => __( 'Name Override', 'cmb2' ),
+            'object_types'  => array( 'artist' ),
+            'show_in_rest'  => WP_REST_Server::READABLE
+        ) );
+        $cmb->add_field( array(
+            'name'             => __( 'Alternate Name', 'cmb2' ),
+            'desc'             => __( 'Name to use for alphabetical sorting', 'cmb2' ),
+            'id'               => 'artist-sort-name',
+            'type'             => 'text'
+        ) );
+    }
+?>

plugins/cia-post-types/includes/custom-taxonomies.php

@@ -0,0 +1,12 @@
+<?php
+    function create_materials_taxonomy() {
+        $post_types_that_show_materials = [ 'artist', 'exhibition', 'event' ];
+        register_taxonomy('material', $post_types_that_show_materials, [ "label" => "Materials"]);
+    }
+    function create_types_taxonomy() {
+        $post_types = [ 'artist', 'exhibition', 'event' ];
+        foreach ( $post_types as $post_type ):
+            register_taxonomy($post_type . '_type', $post_type, [ "label" => ucfirst($post_type) . " Type"]);
+        endforeach;
+    }
+?>