:recycle: returning lists of posts with pagination

plugins/cia-endpoints/includes/class.make-endpoint.php

@@ -44,8 +44,11 @@ class Make_Endpoint_For extends WP_REST_Controller {
     }
     public function get_all_items( $request ) {
         $args = array(
-            'numberposts' => 999999,
             'post_type' => $this->post_type,
+            'post_status' => ['publish'],
+            //(int) - number of post to show per page (available with Version 2.1). Use 'posts_per_page' => -1 to show all posts. 
+            'posts_per_page' => -1,
+            'page' => 1
             // Order DOES NOT WORK because you're
             // returning the posts by id - DUH
             // 'orderby' => 'date',
@@ -55,8 +58,16 @@ class Make_Endpoint_For extends WP_REST_Controller {
         // Get parameters from request
         // /<id>?limit=<num>
         $params = $request->get_params();
-        if(intval($params['limit']) > 0) { $args['numberposts'] = intval($params['limit']); }
-        if(intval($params['id']) > 0) { $args['include'] = array($params['id']); }
+        if(intval($params['limit']) > 0) {
+            $args['posts_per_page'] = intval($params['limit']);
+        }
+        if(intval($params['id']) > 0) {
+            $args['include'] = array($params['id']);
+        }
+        if(intval($params['p']) > 1) {
+            $args['page'] = intval($params['p']);
+            $args['offset'] = ($args['page'] * $args['posts_per_page']) - $args['posts_per_page'];
+        }
         // !: Add order asc/desc
         // !: Add orderby
 
@@ -86,40 +97,43 @@ class Make_Endpoint_For extends WP_REST_Controller {
             
             if($item->post_type === 'episode') $filtered[credits] = get_post_meta( $item->ID, 'credits', true );
 
-            $collection[$item->ID] = $filtered;
+            array_push($collection, $filtered);
         }
         wp_reset_postdata();
 
         return $collection;
     }
     public function prepare_all_items_for_response( $args ) {
-        $collection = array();
+        $collection = [];
         $alphabet_section = 'a';
+        
+        $q = new WP_Query( $args );
 
-        // https://developer.wordpress.org/reference/functions/get_posts/
-        foreach( get_posts($args) as $item ) {
+        $args['max'] = $q->max_num_pages;
+        $found_posts = $q->get_posts();
+
+        foreach( $found_posts as $post ) {
             // print_r($args);
-            // print_r($item);
-            $filtered = default_post_format( $item, true );
+            // print_r($post);
+            $formatted = default_post_format( $post, true );
 
             // For your hero URL
-            $filtered[hero] = get_post_meta( $item->ID, 'hero_header', true );
+            $formatted[hero] = get_post_meta( $post->ID, 'hero_header', true );
 
             // Sticky
-            $filtered[sticky] = get_post_meta( $item->ID, 'is_sticky', true );
-
-            if($item->post_type == 'page') {
-                $filtered[content] = $item->post_content;
-            }
+            $formatted[sticky] = get_post_meta( $post->ID, 'is_sticky', true );
             
-            if($item->post_type == 'artist') {
-                // This is where you add to your letter counter
-            }
+            // Don't use the BLOCK system for pages for some reason
+            if($post->post_type == 'page') $formatted[content] = $post->post_content;
+            
+            // This is where you add to your letter counter
+            if($post->post_type == 'artist') {}
 
-            array_push($collection, $filtered);
+            array_push($collection, $formatted);
         }
         wp_reset_postdata();
-
+        
+        $collection['_meta'] = $args;
         return $collection;
     }
 }