:recycle: trying to unify set hero logic

vue-theme/src/pages/index.vue

@@ -84,11 +84,21 @@ export default {
     methods: {
         async checkAndSetHero(type) {
             if (!this['allPagesLoaded']) {
-                await this.$store.dispatch('getAllPages')
+                await this.$store.dispatch('getAllPages', { sortType: null, params: null })
             }
-            const page = this.allPages[type]
-            if (!page) return
-            let json = { url: page.featured, heroType: 'image' }
+            // We always set a hero no matter what
+            // Because the hero component will deal
+            // with how to render based on hero.url
+            const page = this.allPages.filter(
+                page => page.slug == type + 's',
+            )[0]
+            let hero = { url: null, heroType: null }
+            
+            // Clear the hero and bail
+            if(!page) return this.$store.commit('SET_HERO', hero)
+
+            hero.url = page.featured
+            hero.heroType = 'image'
             if (
                 page.hero &&
                 JSON.parse(page.hero) &&
@@ -97,7 +107,13 @@ export default {
                 json = JSON.parse(page.hero)
                 json.heroType = 'video'
             }
-            this.$store.commit('SET_HERO', json)
+            // No featured or youTube
+            if (!hero.url) {
+                hero.heroType = null
+            }
+            // Set the hero text to the post title or excerpt
+            hero.text = page && page.excerpt ? page.excerpt : page.title
+            this.$store.commit('SET_HERO', hero)
         },
         firstPostOfType(type) {
             return Object.values(this[`all${convertTitleCase(type)}s`])[0]

vue-theme/src/pages/list.vue

@@ -132,7 +132,7 @@ export default {
         },
         async checkAndSetHero(type) {
             if (!this['allPagesLoaded']) {
-                await this.$store.dispatch('getAllPages', { sortType: null, params: null})
+                await this.$store.dispatch('getAllPages', { sortType: null, params: null })
             }
 
             // We always set a hero no matter what
@@ -195,7 +195,7 @@ export default {
                 // console.warn('sort not found:', sort)
                 sort = null
             }
-            
+
             // TODO: Track last loaded page per post type
             // Less http calls
             this.page = 1