:recycle: Greatly simplified refactor using map over reduce

backend/lib/routes/membership/active.js

@@ -95,45 +95,24 @@ module.exports = {
                 false,
             )
 
-            /** Grabs the reveal tags for the target profile */
-            const revealTags = await groupings.reduce(
-                async (revealTags, grouping) => {
-                    for (const profile of completedProfiles) {
-                        revealTags = await profileService.
-                            getTagsFor(
-                                profile.profile_id,
-                                grouping.grouping_id,
-                                'reveal')
-                        if (revealTags.length) return revealTags
-                    }
-                }, [])
+            /** Grabs revealTags */
+            const profileIdsFromCompletedProfiles = completedProfiles.map(p => p.profile_id)
+            const groupingIdsFromGroupings = groupings.map(g => g.grouping_id)
+            const revealTags = await profileService.getTagsFor(profileIdsFromCompletedProfiles, groupingIdsFromGroupings, 'reveal')
 
             /** If the revealTags exist, the completedProfile's hidden info is
              * removed and replaced with the completedProfile's user information
              * Otherwise the completedProfiles remain unchanged
              */
-            completedProfiles = await completedProfiles.reduce(
-                async (profilesWithRevealed, profile) => {
-                    if (!revealTags) return completedProfiles
-                    const user = await userService.findById(profile.user_id)
-                    if (user) {
-                        for (const t of revealTags)
-                            if (t.tag.tag_description)
-                                profile[t.tag.tag_description] = 
-                                    user[t.tag.tag_description]
-                        profilesWithRevealed = profile
-                        return profilesWithRevealed = 
-                            profilesWithRevealed.length ? 
-                                profilesWithRevealed : 
-                                completedProfiles
-                    } else {
-                        // TODO: consider removing, throwIfNotFound used in findById
-                        console.error(
-                            '[User Service Error] no user id found for profile id >> ', 
-                            profile.profile_id)
-                        return completedProfiles
+            const userIdsFromCompletedProfiles = completedProfiles.map(p => p.user_id)
+            const user = await userService.findById(userIdsFromCompletedProfiles)
+            if (revealTags && user) {
+                for (const t of revealTags) {
+                    if (t.tag.tag_description) {
+                        completedProfiles[0][t.tag.tag_description] = user[t.tag.tag_description]
                     }
-                }, [])
+                }
+            }
 
             const reformattedGroupings = groupings.map(g => {
                 completedProfiles.forEach(p => {