#94 brian_auth_fix

Unito
maeda ha unito 2 commit da brian_auth_fix a dev 2 anni fa
tomit4 2 anni fa ha commentato

This pull request includes a couple fixes to a few bugs that occurred due to small inaccuracies in logic implemented during the recent refactor.

These bugs included:

  • Redirection to login upon first page visit instead of splash/onboarding page (fixed by replacing destination.meta.requiresCompleteProfile with destination.meta.requriesAuth inn guards.js, line 36
  • Redirection back to /onboarding even after answering intial sign up email (fixed by adjusting conditional clause that checks for userSession.email in validate-sessionl.js, line 62).

Additionally, smaller changes in error handling were addressed on the frontend/backend, passing the error message from the backend in both validate-session.js and verify-session.js under each respective catch(err) clause. Additionally, on the frontend’s auth.service.js, an additional check for the presence of this .error property is checked in the return value and then a new Error is thrown if the property exists.

This should resolve basic sign up and login bugs that have occurred, allowing the user to once again sign up and log in as expected.

This pull request includes a couple fixes to a few bugs that occurred due to small inaccuracies in logic implemented during the recent refactor. These bugs included: - [x] Redirection to login upon first page visit instead of splash/onboarding page (fixed by replacing destination.meta.requiresCompleteProfile with destination.meta.requriesAuth inn guards.js, line 36 - [x] Redirection back to /onboarding even after answering intial sign up email (fixed by adjusting conditional clause that checks for userSession.email in validate-sessionl.js, line 62). Additionally, smaller changes in error handling were addressed on the frontend/backend, passing the error message from the backend in both validate-session.js and verify-session.js under each respective catch(err) clause. Additionally, on the frontend's auth.service.js, an additional check for the presence of this .error property is checked in the return value and then a new Error is thrown if the property exists. This should resolve basic sign up and login bugs that have occurred, allowing the user to once again sign up and log in as expected.
maeda è stato assegnato da tomit4 2 anni fa
La pull request è stata unita.
Effettua l'accesso per partecipare alla conversazione.
Nessuna etichetta
!
$
$$
$$$
?
API
Nessuna milestone
No Assignees
1 Partecipanti
Data di scadenza

Nessuna data di scadenza impostata.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
Annulla
Salva
Non ci sono ancora contenuti.